[BugFix] Set default value for normalize_advantage to False. (#2050)

pytorch · Apr 2, 2024 · 2461eb2 · 2461eb2
1 parent 2c485dd
commit 2461eb2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/torchrl/objectives/ppo.py b/torchrl/objectives/ppo.py
@@ -774,7 +774,7 @@ def __init__(
         entropy_coef: float = 0.01,
         critic_coef: float = 1.0,
         loss_critic_type: str = "smooth_l1",
-        normalize_advantage: bool = True,
+        normalize_advantage: bool = False,
         gamma: float = None,
         separate_losses: bool = False,
         reduction: str = None,
@@ -1007,7 +1007,7 @@ def __init__(
         entropy_coef: float = 0.01,
         critic_coef: float = 1.0,
         loss_critic_type: str = "smooth_l1",
-        normalize_advantage: bool = True,
+        normalize_advantage: bool = False,
         gamma: float = None,
         separate_losses: bool = False,
         reduction: str = None,