Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define and disable the caffe2_serialize target in Bazel #75942

Closed
wants to merge 28 commits into from

Conversation

This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 16, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit bf5ad78 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Michael Andreas Dagitses added 8 commits April 16, 2022 14:04
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
Michael Andreas Dagitses added 4 commits April 18, 2022 06:52
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits April 21, 2022 07:22
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
Michael Andreas Dagitses added 4 commits April 21, 2022 08:08
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits April 21, 2022 09:11
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
Michael Andreas Dagitses added 3 commits April 21, 2022 09:37
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
Michael Andreas Dagitses added 4 commits April 22, 2022 10:00
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Apr 25, 2022
Summary:
Pull Request resolved: #75942

This also requires changes to the target definition and the xplat translator to get it working.
ghstack-source-id: 154678046

Test Plan: Verify locally and rely on CI.

Reviewed By: malfet

Differential Revision: D35704597

fbshipit-source-id: 6b0d9f5a044609b24dda656f80233ba6186c097f
@github-actions
Copy link
Contributor

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants