Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python Exceptions: frontend change #72899

Closed
wants to merge 1 commit into from
Closed

(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python Exceptions: frontend change #72899

wants to merge 1 commit into from

Conversation

shunting314
Copy link
Contributor

@shunting314 shunting314 commented Feb 16, 2022 •
edited
Loading

Stack from ghstack:

Reland D33282878. This is the frontend change.

Differential Revision: D34252127

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@shunting314
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
18e77bc 
… Exceptions: frontend change

Reland D33282878. This is the frontend change.

Differential Revision: [D34252127](https://our.internmc.facebook.com/intern/diff/D34252127/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34252127/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 16, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 18e77bc (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 16, 2022

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/18e77bc128a8bb9491632312d4e47e3f1343cca2/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-manywheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk, ciflow/xla ✅ triggered
linux-bionic-rocm4.5-py3.7 ciflow/all, ciflow/default, ciflow/linux, ciflow/rocm, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-arm64-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-arm64-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
macos-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
windows-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Feb 16, 2022
shunting314 added a commit that referenced this pull request Feb 16, 2022
@shunting314
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
52ab620 
… Exceptions: frontend change

Reland D33282878. This is the frontend change.

Differential Revision: [D34252127](https://our.internmc.facebook.com/intern/diff/D34252127/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34252127/)!

ghstack-source-id: 149204031
Pull Request resolved: #72899
facebook-github-bot pushed a commit that referenced this pull request Feb 16, 2022
@shunting314 @facebook-github-bot
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
1d276ba 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: #72899

Reland D33282878 (911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
3dc74d4 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
c3ef8b1 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
01b08a4 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
582865e 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
64cd1dc 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
7caf380 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
2013b31 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
@facebook-github-bot facebook-github-bot deleted the gh/shunting314/19/head branch February 19, 2022 15:17
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 20, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
c3ebc03 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 20, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
cc0a916 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 20, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
109883f 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 21, 2022
@shunting314 @cyyever
(2/2) Make TorchScript Preserve Fully Qualified Class Name for Python…
1fed907 
… Exceptions: frontend change (#72899)

Summary:
Pull Request resolved: pytorch/pytorch#72899

Reland D33282878 (pytorch/pytorch@911d527). This is the frontend change.
ghstack-source-id: 149204031

Test Plan: Refer to D33282878 (pytorch/pytorch@911d527). Also check CI

Reviewed By: gmagogsfm

Differential Revision: D34252127

fbshipit-source-id: 27b17ddd4d05d904eb91fd9ee094d9121f00e388
(cherry picked from commit 1d276baca308110ac40111ccd622400b3bbdc864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunting314 @facebook-github-bot