use irange for loops #66234
Closed
use irange for loops #66234
+22,184
−21,930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-barnes
requested review from
albanD,
IvanYashchuk,
lezcano,
nikitaved and
soulitzer
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 13a51ce (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
976427f to
0b0ffff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
0b0ffff to
2cbe568
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
2cbe568 to
9804ea0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
9804ea0 to
76820a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
76820a9 to
ff259cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
ff259cb to
ab591f0
Compare
r-barnes
force-pushed
the
export-D30652629
branch
from
ab591f0 to
956083f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
956083f to
351420f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
351420f to
978da84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
978da84 to
b90ae37
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
r-barnes
force-pushed
the
export-D30652629
branch
from
b90ae37 to
ec46f43
Compare
Summary: Pull Request resolved: pytorch#66234 Modified loops in files under fbsource/fbcode/caffe2/ from the format `for(TYPE var=x0;var<x_max;x++)` to the format `for(const auto var: irange(xmax))` This was achieved by running r-barnes's loop upgrader script (D28874212) with some modification to exclude all files under /torch/jit and a number of reversions or unused variable suppression warnings added by hand. Test Plan: Sandcastle Differential Revision: D30652629 fbshipit-source-id: a0532fcb0fee256b1b97b7a2bd5204d7dac24650
r-barnes
force-pushed
the
export-D30652629
branch
from
ec46f43 to
13a51ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30652629 |
|
This pull request has been merged in 687c226. |
|
This pull request has been reverted by 2f099c7. To re-land this change, follow these steps. |
|
This pull request has been reverted by 2f099c7. To re-land this change, follow these steps. |
wconstab
pushed a commit
that referenced
this pull request
Oct 20, 2021
Summary: Pull Request resolved: #66234 Modified loops in files under fbsource/fbcode/caffe2/ from the format `for(TYPE var=x0;var<x_max;x++)` to the format `for(const auto var: irange(xmax))` This was achieved by running r-barnes's loop upgrader script (D28874212) with some modification to exclude all files under /torch/jit and a number of reversions or unused variable suppression warnings added by hand. bypass_size_limit allow-large-files Test Plan: Sandcastle Reviewed By: ngimel Differential Revision: D30652629 fbshipit-source-id: 0ae6c4bbbb554bad42e372792a6430e1acf15e3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Modified loops in files under fbsource/fbcode/caffe2/ from the format
for(TYPE var=x0;var<x_max;x++)to the format
for(const auto var: irange(xmax))This was achieved by running r-barnes's loop upgrader script (D28874212) with some modification to exclude all files under /torch/jit.
Test Plan:
buck run //caffe2/torch/fb/sparsenn:testDifferential Revision: D30652629
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang