-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] disable test test_Conv2d_groups_nobias for ROCm #59158
Closed
jaglinux
wants to merge
1
commit into
pytorch:master
from
jaglinux:origin/disable_test_Conv2d_groups_nobias
Closed
[ROCm] disable test test_Conv2d_groups_nobias for ROCm #59158
jaglinux
wants to merge
1
commit into
pytorch:master
from
jaglinux:origin/disable_test_Conv2d_groups_nobias
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling the test since its failing in ROCm4.2 Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
💊 CI failures summary and remediationsAs of commit 3a9deab (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ngimel
approved these changes
Jun 1, 2021
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
pushed a commit
to malfet/pytorch
that referenced
this pull request
Jun 2, 2021
Summary: Disabling the test since its failing in ROCm4.2 Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Pull Request resolved: pytorch#59158 Reviewed By: mruberry Differential Revision: D28808953 Pulled By: ngimel fbshipit-source-id: 134f147ead6dc559d2cde49cf8343cd976e6c224
This was referenced Jun 2, 2021
malfet
added a commit
that referenced
this pull request
Jun 2, 2021
* [ROCm] disable test test_Conv2d_groups_nobias for ROCm (#59158) Summary: Disabling the test since its failing in ROCm4.2 Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Pull Request resolved: #59158 Reviewed By: mruberry Differential Revision: D28808953 Pulled By: ngimel fbshipit-source-id: 134f147ead6dc559d2cde49cf8343cd976e6c224 * [ROCm] disable test test_Conv2d_groups_nobias_v2 for ROCm (#58701) Summary: Disable test_Conv2d_groups_nobias_v2 test because it is failing on ROCm 4.2 Pull Request resolved: #58701 Reviewed By: ngimel Differential Revision: D28626651 Pulled By: mruberry fbshipit-source-id: a74bdf45335ae2afee0aa5e3bece6e208e75a63f Co-authored-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Co-authored-by: Kyle Chen <kylechen@amd.com>
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Disabling the test since its failing in ROCm4.2 Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Pull Request resolved: pytorch#59158 Reviewed By: mruberry Differential Revision: D28808953 Pulled By: ngimel fbshipit-source-id: 134f147ead6dc559d2cde49cf8343cd976e6c224
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 1, 2022
fixes: #59158 #58701 Pull Request resolved: #75008 Approved by: https://github.com/albanD
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
Summary: fixes: #59158 #58701 Pull Request resolved: #75008 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f888dc584214948e9048070d3ba972d5df776846 Reviewed By: atalman Differential Revision: D35359967 fbshipit-source-id: 2ed62725d0fe3eec29b504070ec2450d2fd2a5f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the test since its failing in ROCm4.2
Signed-off-by: Jagadish Krishnamoorthy jagdish.krishna@gmail.com