Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nn] nn.Embedding : padding_idx doc update #53809

Closed

Conversation

kshitij12345
Copy link
Collaborator

Follow-up of #53447

Reference: #53447 (comment)

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 11, 2021

💊 CI failures summary and remediations

As of commit 4b4d0fa (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@kshitij12345 kshitij12345 marked this pull request as ready for review March 11, 2021 14:29
@kshitij12345 kshitij12345 requested a review from albanD as a code owner March 11, 2021 14:29
@kshitij12345 kshitij12345 removed the request for review from albanD March 11, 2021 14:30
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 12, 2021
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for updating these docs :)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jbschlosser jbschlosser added this to the 1.8.1 milestone Mar 15, 2021
@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in c1a3962.

malfet pushed a commit to malfet/pytorch that referenced this pull request Mar 15, 2021
Summary:
Follow-up of pytorch#53447

Reference: pytorch#53447 (comment)

Pull Request resolved: pytorch#53809

Reviewed By: bdhirsh

Differential Revision: D27049643

Pulled By: jbschlosser

fbshipit-source-id: 623a2a254783b86391dc2b0777b688506adb4c0e
@kshitij12345 kshitij12345 deleted the docs/embedding-padding-idx branch March 16, 2021 06:31
malfet added a commit that referenced this pull request Mar 16, 2021
Summary:
Follow-up of #53447

Reference: #53447 (comment)

Pull Request resolved: #53809

Reviewed By: bdhirsh

Differential Revision: D27049643

Pulled By: jbschlosser

fbshipit-source-id: 623a2a254783b86391dc2b0777b688506adb4c0e

Co-authored-by: kshitij12345 <kshitijkalambarkar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants