Add sample validation for LKJCholesky.log_prob #52763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit a08277c (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #52763 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 1972 1972
Lines 216331 216333 +2
=======================================
+ Hits 174811 174815 +4
+ Misses 41520 41518 -2 |
There was a problem hiding this comment.
@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ailzhang - Is it possible to cherry-pick this on to the 1.8 release branch, or is it too late? This change affects validation for the new LKJCholesky distribution and exposes the documentation. |
|
@neerajprad merged this pull request in 0f3a3f2. |
neerajprad
added a commit
that referenced
this pull request
Feb 26, 2021
This is already added to the master branch in #52763.
This was referenced Feb 26, 2021
malfet
pushed a commit
that referenced
this pull request
Feb 26, 2021
This is already added to the master branch in #52763.
This was referenced Mar 10, 2021
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Fixes pytorch#52724. This fixes the following for the LKJCholesky distribution in master: - `log_prob` does sample validation when `validate_args=True`. - exposes documentation for the LKJCholesky distribution. cc. fehiepsi, fritzo Pull Request resolved: pytorch#52763 Reviewed By: anjali411 Differential Revision: D26657216 Pulled By: neerajprad fbshipit-source-id: 12e8f8384cf0c3df8a29564c1e1718d2d6a5833f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52724.
This fixes the following for the LKJCholesky distribution in master:
log_probdoes sample validation whenvalidate_args=True.cc. @fehiepsi, @fritzo