-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Remove InsertQuantDeQuantNode #25000
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
This was referenced Aug 22, 2019
jerryzh168
added a commit
that referenced
this pull request
Aug 22, 2019
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 32ee7473f77b1317f0c2cb3bdc71339e415f8d56 Pull Request resolved: #25000
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
ZolotukhinM
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming everything still works :)
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Closed
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
Summary: Remove deprecated insert_quantdequant pass Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
This pull request has been merged in b15d914. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Remove deprecated insert_quantdequant pass
Test Plan:
.
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17001139