Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove InsertQuantDeQuantNode #25000

Closed
wants to merge 14 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Aug 22, 2019

Stack from ghstack:

Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:

Differential Revision: D17001139

Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 22, 2019
jerryzh168 added a commit that referenced this pull request Aug 22, 2019
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:

ghstack-source-id: 32ee7473f77b1317f0c2cb3bdc71339e415f8d56
Pull Request resolved: #25000
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming everything still works :)

Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 mentioned this pull request Aug 23, 2019
Closed
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:

Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:

Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:

Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
Summary:
Remove deprecated insert_quantdequant pass

Test Plan:
.

Reviewers:
pt1quant

Subscribers:

Tasks:

Tags:

Differential Revision: [D17001139](https://our.internmc.facebook.com/intern/diff/D17001139)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b15d914.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/35/head branch October 28, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants