[quant][graphmode] Integration tests for initial quantization graph mode #24428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
This was referenced Aug 15, 2019
jerryzh168
added a commit
that referenced
this pull request
Aug 15, 2019
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 033c0b469342e4a617b1644b9c112e0b337da744 Pull Request resolved: #24428
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Aug 15, 2019
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 7e1980c6e5e02b740db50299fc8be69a1cde35e1 Pull Request resolved: #24428
ezyang
added
oncall: quantization
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Aug 17, 2019
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: f5ef924bfed2b850a3567dcd5b2d49f3ed5d52f6 Pull Request resolved: #24428
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Aug 20, 2019
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 0edb1aac7bb62fddaad500f6510f6fcbcfdcb7e3 Pull Request resolved: #24428
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Aug 21, 2019
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 67e190bdf8c15904cf2ce9d839277fe7cb585ccd Pull Request resolved: #24428
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Aug 21, 2019
Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 276d5220cd867fed19ec90e1427274ff14c3eb0d Pull Request resolved: #24428
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
This was referenced Aug 22, 2019
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
ZolotukhinM
approved these changes
Aug 23, 2019
test/test_quantizer.py
Outdated
| script_module = TestScriptM() | ||
| script_module.conv.weight = torch.nn.Parameter(eager_module.conv.weight.detach()) | ||
| quantized_eager_module = quantize(eager_module, default_eval_fn, data) | ||
| torch._C._jit_set_inline_everything_mode(False) |
There was a problem hiding this comment.
It's better to use the corresponding decorator on a function to make sure we don't affect other tests.
There was a problem hiding this comment.
we actually need to inline for now and don't inline will be supported later, this line has no effect right now since it is after creation of ScriptModule
| @@ -222,3 +225,110 @@ def forward(self, x): | |||
| self.assertTrue('z' in eagerDict and 'z.1' in activationDict) | |||
| self.assertAlmostEqual(eagerDict["z"][0], activationDict["z.1"][0], places=15) | |||
| self.assertAlmostEqual(eagerDict["z"][1], activationDict["z.1"][1], places=15) | |||
|
|
|||
| def test_compare_qparam_eager_script_default(self): | |||
There was a problem hiding this comment.
Nit: what do 'qparam' and 'default' words mean in the name of this test?
There was a problem hiding this comment.
I plan to rename this to test_default in later PR..
default just means simple/naive situation, maybe I can rename that to test_simple
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
Closed
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags:
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001136](https://our.internmc.facebook.com/intern/diff/D17001136)
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001136](https://our.internmc.facebook.com/intern/diff/D17001136)
…ion graph mode" Summary: att Test Plan: python test/test_quantizer.py Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001136](https://our.internmc.facebook.com/intern/diff/D17001136)
|
This pull request has been merged in a1bf4d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
att
Test Plan:
python test/test_quantizer.py
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17001136