Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fx graph runnable to tl parse #130976

Closed
wants to merge 5 commits into from
Closed

Add fx graph runnable to tl parse #130976

wants to merge 5 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Jul 17, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130976

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 967e3aa with merge base df0494b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Jul 17, 2024
@eellison
Add fx graph runnable to tl parse
191c08d 
ghstack-source-id: 0a056e9f681e38e8090aae451dee77bd3e3622ed
Pull Request resolved: #130976
@eellison eellison requested a review from ezyang July 17, 2024 19:49
@eellison
Update on "Add fx graph runnable to tl parse"
3b1092b 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jul 18, 2024
@eellison
Add fx graph runnable to tl parse
0bddde8 
ghstack-source-id: 5f8bfee047c41036d2e51277cd1f63365397fb3f
Pull Request resolved: #130976
@eellison
Update on "Add fx graph runnable to tl parse"
637744f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jul 29, 2024
@eellison
Add fx graph runnable to tl parse
24d1387 
ghstack-source-id: 3c36486ea9e9747505832978f5d3053eac1e1ae1
Pull Request resolved: #130976
@eellison
Update on "Add fx graph runnable to tl parse"
2ebbc9f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jul 30, 2024
@eellison
Add fx graph runnable to tl parse
f070cd0 
ghstack-source-id: 9e63bb28bb9db2eb39f78787a886a314ce41baf9
Pull Request resolved: #130976
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 30, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@eellison eellison added the topic: not user facing topic category label Jul 31, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eellison
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, amz2023.linux.4xlarge.nvidia.gpu), inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (inductor_avx2, 2, 2, linux.10xlarge.avx2), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 2, 2, linux.g5.4xlarge.nvidia.gpu), inductor / cuda12.1-py3.12-gcc9-sm86 / test (inductor, 2, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Jul 31, 2024

@pytorchbot revert -m "Broke trunk" -c nosignal

See example failure here: https://hud.pytorch.org/pytorch/pytorch/commit/91299c95ece5b51902abf2dad9cb11ca550c72fe

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 31, 2024
@pytorchmergebot
Revert "Add fx graph runnable to tl parse (#130976)"
5406e46 
This reverts commit 52c3af6.

Reverted #130976 on behalf of https://github.com/albanD due to Broke trunk ([comment](#130976 (comment)))
@pytorchmergebot
Copy link
Collaborator

@eellison your PR has been successfully reverted.

@eellison
Update on "Add fx graph runnable to tl parse"
967e3aa 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jul 31, 2024
@eellison
Add fx graph runnable to tl parse
645d7b8 
ghstack-source-id: 336dc0c30db4bd246fde31af7c2f97de88a93084
Pull Request resolved: #130976
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@henrylhtsang henrylhtsang mentioned this pull request Jul 31, 2024
Closed
@github-actions github-actions bot deleted the gh/eellison/672/head branch August 31, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eellison @pytorchmergebot @albanD @ezyang