Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Optimization with constraint (L-BFGS-B) #6564

Open
diaoenmao opened this issue Apr 12, 2018 · 4 comments
Open

[Feature Request] Optimization with constraint (L-BFGS-B) #6564

diaoenmao opened this issue Apr 12, 2018 · 4 comments
Labels
proposal accepted The core team has reviewed the feature request and agreed it would be a useful addition to PyTorch todo Not as important as medium or high priority tasks, but we will work on these. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@diaoenmao
Copy link

Is there an agenda for implementing bounded optimization method like L-BFGS-B?
Scipy already has a functional method here scipy.optimize.fmin_l_bfgs_b.
@zou3519 zou3519 added the proposal accepted The core team has reviewed the feature request and agreed it would be a useful addition to PyTorch label Apr 16, 2018
@zou3519 zou3519 added the todo Not as important as medium or high priority tasks, but we will work on these. label May 14, 2018
@hassec
Copy link

hassec commented May 18, 2018

Not sure if it helps you but it seems that somebody already attempted this in #938.

@hassec hassec mentioned this issue Jun 23, 2018
Closed
@kamathhrishi
Copy link

This has been implemented on https://pytorch.org/docs/stable/_modules/torch/optim/lbfgs.html. Could you please close this issue since it gets confusing.

@soumith
Copy link
Member

soumith commented Mar 27, 2019

@kamathhrishi no the base LBFGS doesn't have what this issue is asking for. See referenced PR as well.

@kamathhrishi
Copy link

@soumith Oh my bad. Alright then , Thank you. I looked into the PR.

@vincentqb vincentqb mentioned this issue Jul 9, 2019
Open
@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 16, 2020
@shuheng-liu shuheng-liu mentioned this issue Feb 12, 2021
Closed
@nateanl nateanl mentioned this issue Jul 13, 2022
Closed
@tvercaut tvercaut mentioned this issue Sep 26, 2023
Open
huydhn added a commit to huydhn/pytorch that referenced this issue Nov 5, 2024
@huydhn
Fix ExecuTorch CI after landing pytorch#6564
c902668
pytorchmergebot pushed a commit that referenced this issue Nov 6, 2024
@huydhn @pytorchmergebot
Fix ExecuTorch CI after landing #6564 (#139700)
ed16f28 
After landing pytorch/executorch#6564, we need to update the pinned ExecuTorch commit on PyTorch is fix the regression on PyTorch side.  The change to `.ci/docker/common/install_executorch.sh` is needed because it's how the dependencies are setup on ExecuTorch CI now.
Pull Request resolved: #139700
Approved by: https://github.com/larryliu0820, https://github.com/malfet
atalman pushed a commit to atalman/pytorch that referenced this issue Nov 11, 2024
@huydhn @atalman
Fix ExecuTorch CI after landing pytorch#6564 (pytorch#139700)
3825946 
After landing pytorch/executorch#6564, we need to update the pinned ExecuTorch commit on PyTorch is fix the regression on PyTorch side.  The change to `.ci/docker/common/install_executorch.sh` is needed because it's how the dependencies are setup on ExecuTorch CI now.
Pull Request resolved: pytorch#139700
Approved by: https://github.com/larryliu0820, https://github.com/malfet
zero000064 pushed a commit to zero000064/pytorch that referenced this issue Nov 14, 2024
@huydhn @zero000064
Fix ExecuTorch CI after landing pytorch#6564 (pytorch#139700)
2ded4d1 
After landing pytorch/executorch#6564, we need to update the pinned ExecuTorch commit on PyTorch is fix the regression on PyTorch side.  The change to `.ci/docker/common/install_executorch.sh` is needed because it's how the dependencies are setup on ExecuTorch CI now.
Pull Request resolved: pytorch#139700
Approved by: https://github.com/larryliu0820, https://github.com/malfet
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this issue Dec 2, 2024
@huydhn @Ryo-not-rio
Fix ExecuTorch CI after landing pytorch#6564 (pytorch#139700)
97e4d83 
After landing pytorch/executorch#6564, we need to update the pinned ExecuTorch commit on PyTorch is fix the regression on PyTorch side.  The change to `.ci/docker/common/install_executorch.sh` is needed because it's how the dependencies are setup on ExecuTorch CI now.
Pull Request resolved: pytorch#139700
Approved by: https://github.com/larryliu0820, https://github.com/malfet
pobin6 pushed a commit to pobin6/pytorch that referenced this issue Dec 5, 2024
@huydhn
Fix ExecuTorch CI after landing pytorch#6564 (pytorch#139700)
40f3f6e 
After landing pytorch/executorch#6564, we need to update the pinned ExecuTorch commit on PyTorch is fix the regression on PyTorch side.  The change to `.ci/docker/common/install_executorch.sh` is needed because it's how the dependencies are setup on ExecuTorch CI now.
Pull Request resolved: pytorch#139700
Approved by: https://github.com/larryliu0820, https://github.com/malfet
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this issue Dec 11, 2024
@huydhn @fmo-mt
Fix ExecuTorch CI after landing pytorch#6564 (pytorch#139700)
2ee4e6a 
After landing pytorch/executorch#6564, we need to update the pinned ExecuTorch commit on PyTorch is fix the regression on PyTorch side.  The change to `.ci/docker/common/install_executorch.sh` is needed because it's how the dependencies are setup on ExecuTorch CI now.
Pull Request resolved: pytorch#139700
Approved by: https://github.com/larryliu0820, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal accepted The core team has reviewed the feature request and agreed it would be a useful addition to PyTorch todo Not as important as medium or high priority tasks, but we will work on these. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@soumith @ailzhang @kamathhrishi @zou3519 @diaoenmao @hassec