Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 797 #817

Merged
merged 21 commits into from
Mar 1, 2020
Merged

Issue 797 #817

merged 21 commits into from
Mar 1, 2020

Conversation

ykumards
Copy link
Contributor

@ykumards ykumards commented Mar 1, 2020 •
edited
Loading

Fixes #797

Description: PR to achieve the following

  • Move Readme file from RST to Markdown.
  • Add TOC
  • Add links to google colab for all example notebooks
    • Modify notebook examples to run in colab

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5 vfdev-5 marked this pull request as ready for review March 1, 2020 15:27
vfdev-5
vfdev-5 reviewed Mar 1, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Mar 1, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Yogesh !

@vfdev-5 vfdev-5 merged commit 90d4e1b into pytorch:master Mar 1, 2020
@ykumards ykumards deleted the issue-797 branch March 2, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example notebooks to Google Colab
2 participants
@ykumards @vfdev-5