Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak custom_kernel_example test #7985

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Unbreak custom_kernel_example test #7985

merged 1 commit into from
Jan 28, 2025

Conversation

swolchok
Copy link
Contributor

This test doesn't run in OSS CI (#7984), so I missed it.

Test Plan: ran relevant test internally with buck2

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 27, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Jan 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7985

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 7 Pending, 1 Unrelated Failure

As of commit a684e30 with merge base da0d85d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jan 27, 2025
This test doesn't run in OSS CI (#7984), so I missed it.

Test Plan: ran relevant test internally with buck2

ghstack-source-id: f2b994d3bf1091939bad51f5f8455085e91ed8af
ghstack-comment-id: 2617137527
Pull Request resolved: #7985
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2025
@swolchok swolchok requested a review from GregoryComer January 27, 2025 23:57
@swolchok swolchok merged commit 533c1aa into main Jan 28, 2025
43 of 46 checks passed
@swolchok swolchok deleted the gh/swolchok/210/head branch January 28, 2025 00:13
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
This test doesn't run in OSS CI (#7984), so I missed it.

Test Plan: ran relevant test internally with buck2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants