Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git hook suggestions for Arm development #7785

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Jan 21, 2025

Pre-commit runs lintrunner on commited files,
tries applying the changes.
Pre-push does not push if lintrunner or
a simple license check does not pass.

If WIP is included in commit header,
no checks are done.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Pre-commit runs lintrunner on commited files,
tries applying the changes.
Pre-push does not push if lintrunner or
a simple license check does not pass.

If WIP is included in commit header,
no checks are done.

setup-env.sh symlinks the hooks to your
.git/hooks.

install-editable.sh contains commands needed to
do an editable install.

Change-Id: I4c52a1c9d67945b71701f79e8f0913f927d7ea4f
Signed-off-by: Erik Lundell <erik.lundell@arm.com>
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels Jan 21, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
Copy link

pytorch-bot bot commented Jan 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7785

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit bfc10e1 with merge base a4def9f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's discuss some of the comments I left.

backends/arm/scripts/pre-commit Show resolved Hide resolved
backends/arm/scripts/pre-commit Show resolved Hide resolved
@oscarandersson8218 oscarandersson8218 merged commit 3eea1f1 into pytorch:main Jan 29, 2025
40 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants