Fix SCBO tutorial #2034
Fix SCBO tutorial #2034
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #2034 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15891 15889 -2
=========================================
- Hits 15891 15889 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -254,82 +252,101 @@ def __init__( | |||
| objective: Optional[MCAcquisitionObjective] = None, | |||
| posterior_transform: Optional[PosteriorTransform] = None, | |||
| replacement: bool = True, | |||
| minimize_constraints_only: bool = False, | |||
There was a problem hiding this comment.
Should we deprecate this arg so this doesn't cause hard failures in other code?
There was a problem hiding this comment.
I think this should be ok since this functionality probably has no users (that would have likely resulted in Github issues since it wasn't working as intended).
|
@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This fixes several constraint handling bugs in the SCBO tutorial as reported in #2031, #2032, and #2033. In addition, it also fixes a bug and cleans up some of the logic in
ConstrainedMaxPosteriorSampling.The previous problem was too easy, so we never actually tested some of the aspects of the constraint handling. I switched to the same version of the Ackley problem as considered in https://arxiv.org/pdf/2002.08526.pdf and I'm observing comparable performance.