fix LearnedObjective base sample shape #2021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49574252 |
Codecov Report
@@ Coverage Diff @@
## main #2021 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15890 15891 +1
=========================================
+ Hits 15890 15891 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
Sep 27, 2023
Summary: Explicitly specifcy batch_shape in LearnedObjective's sampler to prevent shared base sample in the same batch. Reviewed By: Balandat, esantorella Differential Revision: D49574252
ItsMrLin
force-pushed
the
export-D49574252
branch
from
b79f4c2 to
1d7e7be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49574252 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
Sep 27, 2023
Summary: Explicitly specifcy batch_shape in LearnedObjective's sampler to prevent shared base sample in the same batch. Reviewed By: Balandat, esantorella Differential Revision: D49574252
ItsMrLin
force-pushed
the
export-D49574252
branch
from
1d7e7be to
1cbe222
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49574252 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
Sep 27, 2023
Summary: Explicitly specifcy batch_shape in LearnedObjective's sampler to prevent shared base sample in the same batch. Reviewed By: Balandat, esantorella Differential Revision: D49574252
ItsMrLin
force-pushed
the
export-D49574252
branch
from
1cbe222 to
f80355b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49574252 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
Sep 28, 2023
Summary: Explicitly specifcy batch_shape in LearnedObjective's sampler to prevent shared base sample in the same batch. Reviewed By: Balandat, esantorella Differential Revision: D49574252
ItsMrLin
force-pushed
the
export-D49574252
branch
from
f80355b to
c40a467
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49574252 |
Summary: Explicitly specifcy batch_shape in LearnedObjective's sampler to prevent shared base sample in the same batch. Reviewed By: Balandat, esantorella Differential Revision: D49574252
ItsMrLin
force-pushed
the
export-D49574252
branch
from
c40a467 to
69091e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49574252 |
|
This pull request has been merged in dcb2ba4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Explicitly specifcy batch_shape in LearnedObjective's sampler to prevent shared base sample in the same batch.
Reviewed By: Balandat
Differential Revision: D49574252