Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for 'x' in version constraints #770

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Oct 5, 2024

removes the most bizarre of the many ways in which poetry tries to handle nonsensical version constraints

fixes python-poetry/poetry#5990

@Secrus Secrus added the 2.0 PRs for core 2.0 label Oct 6, 2024
@radoering
Copy link
Member

I think I am fine with the change since it is an undocumented feature.

I thought about deprecating it first because it will hurt some people for sure, especially since it is in the build backend. However, a deprecation is not that simple in this case.

@Secrus Feel free to merge it if you agree to remove it.

@Secrus Secrus enabled auto-merge (squash) October 6, 2024 16:32
@Secrus Secrus merged commit 73afa9e into python-poetry:main Oct 6, 2024
21 checks passed
@dimbleby dimbleby deleted the remove-x-versions branch October 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 PRs for core 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ability to use x in place of * in wildcard specifications, undocumented feature or a bug?
3 participants