Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for Python 3.8 #9692

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

finswimmer
Copy link
Member

Python 3.8 will be EOL on October. Let's drop the support than for running Poetry itself with it.

@TheSven73
Copy link
Contributor

From py3.9 onwards, we can make some executor.py code simpler:

            if self._shutdown:
                # Cancelling further tasks from being executed
                [task.cancel() for task in tasks]
                self._executor.shutdown(wait=True)

=>

            if self._shutdown:
                self._executor.shutdown(wait=True, cancel_futures=True)

@finswimmer finswimmer marked this pull request as ready for review September 23, 2024 19:09
@finswimmer finswimmer force-pushed the drop-python38 branch 2 times, most recently from b8189a1 to 0963d48 Compare September 23, 2024 20:13
@finswimmer finswimmer requested a review from a team September 24, 2024 07:17
@finswimmer finswimmer force-pushed the drop-python38 branch 2 times, most recently from 9807b17 to 2d5bd65 Compare October 5, 2024 15:44
@Secrus Secrus added this to the Poetry 2.0 milestone Oct 6, 2024
@finswimmer finswimmer force-pushed the drop-python38 branch 3 times, most recently from ca34402 to 3a1627c Compare October 12, 2024 14:52
@radoering radoering enabled auto-merge (squash) October 20, 2024 10:49
@radoering radoering merged commit ab0880c into python-poetry:main Oct 20, 2024
73 checks passed
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
Co-authored-by: Sven van Ashbrook <thesven73@googlemail.com>
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants