Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize some repo metastuff and prepare v1.9.0 #364

Merged
merged 10 commits into from
Dec 22, 2023
Merged

Optimize some repo metastuff and prepare v1.9.0 #364

merged 10 commits into from
Dec 22, 2023

Conversation

nir0s
Copy link
Collaborator

@nir0s nir0s commented Dec 19, 2023

Nothing too fancy. See commit messages.

btw, just noting that codecov doesn't work and that there are some discussions about this: codecov/codecov-action#844

Also fixes #357

Copy link
Member

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, bye 👋

CHANGELOG.md Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/distro/distro.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
src/distro/distro.py Show resolved Hide resolved
@nir0s nir0s requested a review from HorlogeSkynet December 20, 2023 19:04
@nir0s nir0s force-pushed the metawork branch 2 times, most recently from d2794b6 to 756ddba Compare December 20, 2023 19:43
@nir0s
Copy link
Collaborator Author

nir0s commented Dec 20, 2023

@HorlogeSkynet, I added a .readthedocs.yaml config file so that we can start building docs again.

Example: https://distro--364.org.readthedocs.build/en/364/#

@HorlogeSkynet
Copy link
Member

Awewome, this will fix #357 I assume.

@nir0s
Copy link
Collaborator Author

nir0s commented Dec 20, 2023

Awewome, this will fix #357 I assume.

Indeed. I mentioned that in the PR comment.

@nir0s
Copy link
Collaborator Author

nir0s commented Dec 20, 2023

Also wik, we need additional maintainers in RTD.

Copy link
Member

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo my previous picky suggestions 👍

@nir0s
Copy link
Collaborator Author

nir0s commented Dec 20, 2023

LGTM, modulo my previous picky suggestions 👍

WDYM? I fixed all.

@HorlogeSkynet
Copy link
Member

LGTM, modulo my previous picky suggestions 👍

WDYM? I fixed all.

Sorry my bad, there is just one little dangling suggestion for an empty newline in CHANGELOG 🙏

@nir0s nir0s merged commit 8d88a2d into master Dec 22, 2023
24 checks passed
@nir0s nir0s deleted the metawork branch December 22, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on readthedocs is still for version 1.3.0
2 participants