-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize some repo metastuff and prepare v1.9.0 #364
Conversation
Our gitter channel doesn't exist anymore anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, bye 👋
d2794b6
to
756ddba
Compare
@HorlogeSkynet, I added a |
Awewome, this will fix #357 I assume. |
Indeed. I mentioned that in the PR comment. |
Also wik, we need additional maintainers in RTD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo my previous picky suggestions 👍
WDYM? I fixed all. |
Sorry my bad, there is just one little dangling suggestion for an empty newline in CHANGELOG 🙏 |
Nothing too fancy. See commit messages.
btw, just noting that codecov doesn't work and that there are some discussions about this: codecov/codecov-action#844
Also fixes #357