-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore the file '/etc/board-release' #353
Merged
HorlogeSkynet
merged 2 commits into
python-distro:master
from
pedrolamas:pedrolamas/ignore-board-release
Mar 11, 2023
Merged
Ignore the file '/etc/board-release' #353
HorlogeSkynet
merged 2 commits into
python-distro:master
from
pedrolamas:pedrolamas/ignore-board-release
Mar 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @pedrolamas ! Many thanks for your PR, one comment though : could you provide a "testing" rootfs under |
pedrolamas
force-pushed
the
pedrolamas/ignore-board-release
branch
from
February 20, 2023 18:23
2cb365c
to
298d2cf
Compare
Thanks @HorlogeSkynet, I've now added a test for this specific case. |
Thanks ! We'll have to wait for #355 and a proper rebase/merge of this branch 😉 EDIT : Ready for rebase 😇 |
pedrolamas
force-pushed
the
pedrolamas/ignore-board-release
branch
from
February 20, 2023 20:58
298d2cf
to
5cdd431
Compare
pedrolamas
force-pushed
the
pedrolamas/ignore-board-release
branch
from
February 20, 2023 21:01
5cdd431
to
45711d1
Compare
Rebased! 😁 |
HorlogeSkynet
previously approved these changes
Feb 23, 2023
HorlogeSkynet
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
board-release
to ignored patterns, which is used by some Armbian based releases, such as the one used with the BigTreeTech CB1.Full text search here:
https://github.com/bigtreetech/CB1-Kernel/search?q=board-release