Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when uname -rs output is empty #304

Merged
merged 6 commits into from
Sep 26, 2021
Merged

Fix crash when uname -rs output is empty #304

merged 6 commits into from
Sep 26, 2021

Conversation

HorlogeSkynet
Copy link
Member

@HorlogeSkynet HorlogeSkynet commented Jul 29, 2021 •
edited
Loading

closes #264

EDIT : I can backport this patch to the python2.7-support branch if you're OK with that.

@HorlogeSkynet HorlogeSkynet requested review from brejoc and hartwork July 29, 2021 18:03
@HorlogeSkynet HorlogeSkynet self-assigned this Jul 29, 2021
This was referenced Jul 29, 2021
Closed
Merged
brejoc
brejoc previously approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@brejoc brejoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

sethmlarson
sethmlarson reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, instead of changing _uname_info() instead can we change _parse_uname_content to tolerate any input? (And return {} if it gets anything it's not expecting.

@HorlogeSkynet
Copy link
Member Author

Thanks for opening this, instead of changing _uname_info() instead can we change _parse_uname_content to tolerate any input? (And return {} if it gets anything it's not expecting.

Done ! Don't forget to squash my mess.

@HorlogeSkynet HorlogeSkynet requested a review from brejoc September 4, 2021 11:36
@HorlogeSkynet
Copy link
Member Author

Up @brejoc 🙇

brejoc
brejoc approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@brejoc brejoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@HorlogeSkynet HorlogeSkynet merged commit d3e9194 into master Sep 26, 2021
@HorlogeSkynet HorlogeSkynet deleted the fix/uname-rs_empty_output branch September 26, 2021 13:40
@nir0s
Copy link
Collaborator

nir0s commented Sep 26, 2021

Anyone who wants to backport anything to the 2.6/7 branches is more than welcome. The reason we don't officially support EOL is rather obvious, but the branches are there for anyone willing to maintain them.

@HorlogeSkynet
Copy link
Member Author

HorlogeSkynet commented Sep 26, 2021 •
edited
Loading

Yes I was actually on it (for the 2.7) 😉

HorlogeSkynet added a commit that referenced this pull request Sep 26, 2021
@HorlogeSkynet
Fix crash when uname -rs output is empty (#304)
890cddb 
> closes #264
@HorlogeSkynet HorlogeSkynet added this to the 1.6.1 milestone Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brejoc brejoc brejoc approved these changes

@hartwork hartwork Awaiting requested review from hartwork

@sethmlarson sethmlarson Awaiting requested review from sethmlarson

Assignees

@HorlogeSkynet HorlogeSkynet

Labels
area: code area: test bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

If "uname -rs" returns no output, _parse_uname_content causes exception
4 participants
@HorlogeSkynet @nir0s @brejoc @sethmlarson