Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Pythons #281

Merged
merged 4 commits into from
Jul 31, 2021
Merged

Drop support for EOL Pythons #281

merged 4 commits into from
Jul 31, 2021

Conversation

jdufresne
Copy link
Member

Python 2.7 and 3.4, and 3.5 are end of life. They are no longer
receiving bug fixes, including for security issues. For additional
details on support Python versions, see:

Supported: https://devguide.python.org/#status-of-python-branches
EOL: https://devguide.python.org/devcycle/#end-of-life-branches

Removing support for EOL Pythons will reduce testing and maintenance
resources while allowing the library to move towards a modern Python 3
style.

This was referenced Jul 1, 2021
@nir0s
Copy link
Collaborator

nir0s commented Jul 1, 2021

Well, I think that it would be nice to support py27 in a branch like we do with 26, and then drop support in master.

We can have maintainers for these branches. WDYT?

docs/conf.py Outdated Show resolved Hide resolved
@jdufresne
Copy link
Member Author

Well, I think that it would be nice to support py27 in a branch like we do with 26, and then drop support in master.

We can have maintainers for these branches. WDYT?

Works for me. Could someone with permission create a new branch?

@sethmlarson
Copy link
Contributor

If we're going the way of removing Python 2 support are we planning a major release to signal this? Then the branch name could be 1.x?

@jdufresne
Copy link
Member Author

If we're going the way of removing Python 2 support are we planning a major release to signal this? Then the branch name could be 1.x?

This all makes sense to me and is a good idea.

@sethmlarson
Copy link
Contributor

sethmlarson commented Jul 1, 2021

@jdufresne This PR might be hanging out for a while, perhaps we should open an issue so we can discuss what needs to happen outside of code changes to safely drop Python 2? After we get all that out of the way we can then merge this, but it might get out of date in the meantime.

@jdufresne jdufresne mentioned this pull request Jul 1, 2021
5 tasks
@jdufresne
Copy link
Member Author

@jdufresne This PR might be hanging out for a while, perhaps we should open an issue so we can discuss what needs to happen outside of code changes to safely drop Python 2? After we get all that out of the way we can then merge this, but it might get out of date in the meantime.

Good idea. I opened issue #291. Please feel free to add to the checklist if you see other necessary steps.

tests/test_distro.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
sethmlarson
sethmlarson previously approved these changes Jul 10, 2021
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my one comment this change looks good to me :) Thank you!

Python 2.7 and 3.4, and 3.5 are end of life. They are no longer
receiving bug fixes, including for security issues. For additional
details on support Python versions, see:

Supported: https://devguide.python.org/#status-of-python-branches
EOL: https://devguide.python.org/devcycle/#end-of-life-branches

Removing support for EOL Pythons will reduce testing and maintenance
resources while allowing the library to move towards a modern Python 3
style.
Drop 3.4 & 3.5 support.

Add python_requires.
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this awesome PR 💪

@sethmlarson sethmlarson merged commit efd00c4 into python-distro:master Jul 31, 2021
@jdufresne jdufresne deleted the eol-py branch August 2, 2021 01:41
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 17, 2022
https://build.opensuse.org/request/show/955104
by user sebix + dimstar_suse
- remove shebang from distro.py
- update to version 1.7.0:
 - BACKWARD COMPATIBILITY:
 - Dropped support for EOL Pythons 2.7, 3.4 and 3.5 [[#281](python-distro/distro#281)]
 - Dropped support for LSB and `uname` back-ends when `--root-dir` is specified [[#311](python-distro/distro#311)]
 - Moved `distro.py` to `src/distro/distro.py` [[#315](python-distro/distro#315)]
 - ENHANCEMENTS:
 - Documented that `distro.version()` can return an empty string on rolling releases [[#312](python-distro/distro#312)]
 - Documented support for Python 3.10 [[#316](python-distro/distro#316)]
 - Added official support for Rocky Linux distribution [[#318](https://github.com/python-distro/distr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants