dataclasses: various fixes #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
Jan 16, 2021
stdlib/3.7/dataclasses.pyi
Outdated
Comment on lines
21
to
23
| def dataclass(__cls: Type[_T]) -> Type[_T]: ... | ||
| @overload | ||
| def dataclass(_cls: None) -> Callable[[Type[_T]], Type[_T]]: ... | ||
| def dataclass(__cls: None) -> Callable[[Type[_T]], Type[_T]]: ... |
There was a problem hiding this comment.
The stubtest complaints are valid. The following is horrible, but possible:
from dataclasses import dataclass
class Foo:
x: int
y: str
dataclass(_cls=Foo)
print(Foo(42, ""))
added 2 commits
January 16, 2021 11:32
| @@ -76,6 +98,8 @@ def is_dataclass(obj: Any) -> bool: ... | |||
| class FrozenInstanceError(AttributeError): ... | |||
|
|
|||
| class InitVar(Generic[_T]): | |||
There was a problem hiding this comment.
Why is this Generic? Should type be of type Type[_T]?
|
|
||
| if sys.version_info >= (3, 8): | ||
| @overload | ||
| def dataclass(__cls: Type[_T]) -> Type[_T]: ... |
There was a problem hiding this comment.
Took me a long time to figure out that the difference between the branches is __cls vs. _cls. Maybe it's worth a comment.
added 2 commits
January 17, 2021 10:50
|
Thanks, addressed (also fixed up |
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 17, 2021
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 17, 2021
__class_getitem__ and __init_subclass__ are always classmethods, even if they aren't decorated. We previously only handled this correctly if these methods weren't overloaded. This came up in python/typeshed#4937
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Jan 18, 2021
…hod (#9921) __class_getitem__ and __init_subclass__ are always classmethods, even if they aren't decorated. We previously only handled this correctly if these methods weren't overloaded. This came up in python/typeshed#4937 Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.