stubtest: fix signature construction for overload + implicit classmethod #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__class_getitem__ and __init_subclass__ are always classmethods, even if they aren't decorated. We previously only handled this correctly if these methods weren't overloaded. This came up in python/typeshed#4937
| if name in ("__init_subclass__", "__class_getitem__"): | ||
| # These are implicitly classmethods. If the stub chooses not to have @classmethod, we | ||
| # should remove the cls argument | ||
| if args[0].variable.name == "cls": |
There was a problem hiding this comment.
What if I name it _cls instead? It sounds like we should just unconditionally remove the first arg.
There was a problem hiding this comment.
Unconditionally removing the first argument here isn't right, because it'll do the wrong thing if you do choose to decorate with @classmethod, since those get their first argument stripped when resolving the decorator.
I don't think this is important enough to figure out how to chain enough state to keep track of that.
Especially since stubtest currently is picky about classmethod names being cls, e.g. this not-actually-needed-potentially-problematic assert when resolving the classmethod decorator:
Line 815 in 92923b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__class_getitem__and__init_subclass__are always classmethods, even ifthey aren't decorated. We previously only handled this correctly if
these methods weren't overloaded.
This came up in python/typeshed#4937