Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypyc] Build True, False and None op in irbuild #9294

Merged
merged 6 commits into from
Aug 12, 2020
Merged

[mypyc] Build True, False and None op in irbuild #9294

merged 6 commits into from
Aug 12, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

This PR builds three specialized op directly in irbuild, instead of using name_ref_ops.

JukkaL
JukkaL reviewed Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just a few comments.

mypyc/test-data/irbuild-set.test Outdated Show resolved Hide resolved
mypyc/irbuild/ll_builder.py Outdated Show resolved Hide resolved
mypyc/primitives/misc_ops.py Outdated Show resolved Hide resolved
mypyc/test-data/analysis.test Outdated Show resolved Hide resolved
@JukkaL JukkaL merged commit 0dfac58 into python:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TH3CHARLie @JukkaL