Update the release scripts to deal with 3.8 and new filenames #7732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Oct 17, 2019
| self.run_in_virtualenv('misc/download-mypyc-wheels.py %s' % self.version) | ||
| self.run_in_virtualenv( | ||
| '%s %s' % | ||
| (os.path.abspath('misc/download-mypyc-wheels.py'), self.version)) |
There was a problem hiding this comment.
This just allows the script to be run with an arbitrary current working directory?
There was a problem hiding this comment.
This makes it so that we run the download-mypyc-wheels script in the current directory and not in the checkout, since I fixed the script after. I'll add a comment
| @@ -9,14 +9,14 @@ | |||
|
|
|||
|
|
|||
| PLATFORMS = [ | |||
| 'macosx_10_6_x86_64.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64', | |||
| 'macosx_10_{macos_ver}_x86_64', | |||
There was a problem hiding this comment.
What caused this change? What's the distinction between x86_64 and intel?
There was a problem hiding this comment.
I upgraded to a newer version of multibuild, the project we use to build the wheels, and it changed what sort of filenames it produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.