Add test case for global declaration without initializer #6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crashes on old semantic initializer but doesn't crash when using the new semantic analyzer. The error message is pretty poor but that's better than crashing. Closes #5923.
ilevkivskyi
approved these changes
Jun 12, 2019
| def foo() -> None: | ||
| global bar | ||
| # TODO: Confusing error message | ||
| bar = [] # type: List[str] # E: Name 'bar' already defined (possibly by an import) |
There was a problem hiding this comment.
I think this deserves an issue. This is kind of a "fundamental" limitation of the new semantic analyzer. So we should give a dedicated error message and explicitly document that users must write something like this:
bar: List[str]
def foo() -> None:
global bar
bar = []Also note that the Python 3.6 version of this test case is a syntax error:
from typing import List
def foo() -> None:
global bar
bar: List[str] = [] # SyntaxError: annotated name 'bar' can't be globalThere was a problem hiding this comment.
Good points, I'll create a follow-up issue.
There was a problem hiding this comment.
Here's the issue: #6976
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
This crashes on old semantic analyzer but doesn't crash when using the new semantic analyzer. The error message is pretty poor but that's better than crashing. Closes python#5923.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crashes on old semantic initializer but doesn't crash when
using the new semantic analyzer. The error message is pretty
poor but that's better than crashing.
Closes #5923.