Allow class-based TypedDicts in all python versions #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entries can't be *declared* in versions that don't support type annotations, of course, but class-based TypedDict still serves a valuable purpose in merging TypedDicts together. This error *only* triggers on empty TypedDicts, since any non-empty ones would have failed earlier with a syntax error. So there is no reason to prohibit it because we can handle that case totally fine.
gvanrossum
approved these changes
Jun 11, 2019
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Entries can't be *declared* in versions that don't support type annotations, of course, but class-based TypedDict still serves a valuable purpose in merging TypedDicts together. This error *only* triggers on empty TypedDicts, since any non-empty ones would have failed earlier with a syntax error. So there is no reason to prohibit it because we can handle that case totally fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries can't be declared in versions that don't support type
annotations, of course, but class-based TypedDict still serves a
valuable purpose in merging TypedDicts together.
This error only triggers on empty TypedDicts, since any non-empty
ones would have failed earlier with a syntax error. So there is no
reason to prohibit it because we can handle that case totally fine.