Add hooks for running tests on an installed version of mypy #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Nov 16, 2018
The main motivation for all of this is to be able to validate mypy_mypyc wheels. Because the tests are an integrated subpackage of mypy, I couldn't figure out a way to run the tests from the source directory against an installed mypy, and I was reluctant to do a major overhaul of the source organization, in part because some other projects take advantage of some of the test infrastructure (mypyc, sqlalchemy-stubs). So instead we run the tests from where they get installed with the package. To support this, we allow overriding where the tests look for test-data using a `MYPY_TEST_PREFIX` environment variable.
msullivan
force-pushed
the
test-prefix
branch
from
6958ca4 to
e900a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for all of this is to be able to validate
mypy_mypyc wheels.
Because the tests are an integrated subpackage of mypy, I couldn't
figure out a way to run the tests from the source directory against an
installed mypy, and I was reluctant to do a major overhaul of the
source organization, in part because some other projects take
advantage of some of the test infrastructure (mypyc, sqlalchemy-stubs).
So instead we run the tests from where they get installed with the
package. To support this, we allow overriding where the tests look for
test-data using a
MYPY_TEST_PREFIXenvironment variable.