Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asyncio eval tests for 3.14 #18468

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update asyncio eval tests for 3.14 #18468

merged 1 commit into from
Jan 15, 2025

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 15, 2025

Starting in Python 3.14, asyncio.get_event_loop will raise a RuntimeError if no current loop exists in the current thread. Update the eval tests to use asyncio.run instead.

@cdce8p cdce8p added topic-tests topic-async async, await, asyncio labels Jan 15, 2025
JukkaL
JukkaL approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's very helpful to stay up to date with 3.14 development so that we can test with alphas and betas.

@JukkaL JukkaL merged commit c9ed867 into python:master Jan 15, 2025
12 checks passed
@cdce8p cdce8p deleted the update-asyncio-eval-tests branch January 15, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
topic-async async, await, asyncio topic-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @JukkaL