Use polymorphic inference in unification #17348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
|
Hm, it looks like this makes #17206 ( |
|
I also spot-checked new errors and it looks like these are false positives. It looks like they are all caused by the same pattern. I think I know how to fix it, but it is non-trivial, so will do it tomorrow. |
This comment has been minimized.
This comment has been minimized.
|
OK, overload overlap checks are a nightmare. They use some pretty hacky things (I understand it is to avoid duplicating a lot of code in |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/utils.py:539: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
+ steam/ext/commands/commands.py:695: error: Overloaded function signatures 2 and 3 overlap with incompatible return types [overload-overlap]
+ steam/ext/commands/commands.py:741: error: Overloaded function signatures 2 and 3 overlap with incompatible return types [overload-overlap]
+ steam/ext/commands/commands.py:795: error: Overloaded function signatures 2 and 3 overlap with incompatible return types [overload-overlap]
- steam/ext/commands/commands.py:851: error: Overloaded function implementation does not accept all possible arguments of signature 3 [misc]
+ steam/ext/commands/commands.py:844: error: Overloaded function signatures 2 and 3 overlap with incompatible return types [overload-overlap]
Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/commands/menu.py:182: error: Incompatible return value type (got "MenuCommand[_MessageCallbackSigT@__init__, Literal[CommandType.MESSAGE]]", expected "MenuCommand[_MessageCallbackSigT@decorator, Literal[CommandType.MESSAGE]]") [return-value]
- tanjun/commands/menu.py:309: error: Incompatible return value type (got "MenuCommand[_UserCallbackSigT@__init__, Literal[CommandType.USER]]", expected "MenuCommand[_UserCallbackSigT@decorator, Literal[CommandType.USER]]") [return-value]
+ tanjun/commands/menu.py:421: error: Type argument "_UserCallbackSigT" of "MessageCommand" must be a subtype of "Callable[[MessageContext, VarArg(Any), KwArg(Any)], Coroutine[Any, Any, None]]" [type-var]
+ tanjun/commands/menu.py:421: error: Type argument "_UserCallbackSigT" of "SlashCommand" must be a subtype of "Callable[[SlashContext, VarArg(Any), KwArg(Any)], Coroutine[Any, Any, None]]" [type-var]
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ pandas-stubs/core/reshape/concat.pyi:27: error: Overloaded function signatures 1 and 6 overlap with incompatible return types [overload-overlap]
discord.py (https://github.com/Rapptz/discord.py)
+ discord/ext/commands/hybrid.py:911: error: Incompatible return value type (got "Callable[[Callable[[CogT@decorator, ContextT@decorator, **P], Coroutine[Any, Any, T@decorator]] | Callable[[ContextT@decorator, **P], Coroutine[Any, Any, T@decorator]]], HybridCommand[CogT@decorator, P, T@decorator]]", expected "Callable[[Callable[[CogT, ContextT, **P], Coroutine[Any, Any, T]] | Callable[[ContextT, **P], Coroutine[Any, Any, T]]], HybridCommand[CogT, P, T]]") [return-value]
+ discord/ext/commands/hybrid.py:944: error: Incompatible return value type (got "Callable[[Callable[[CogT@decorator, ContextT@decorator, **P], Coroutine[Any, Any, T@decorator]] | Callable[[ContextT@decorator, **P], Coroutine[Any, Any, T@decorator]]], HybridGroup[CogT@decorator, P, T@decorator]]", expected "Callable[[Callable[[CogT, ContextT, **P], Coroutine[Any, Any, T]] | Callable[[ContextT, **P], Coroutine[Any, Any, T]]], HybridGroup[CogT, P, T]]") [return-value]
|
|
@JukkaL @hauntsaninja I am now happy with mypy_primer output, this is ready for review. |
JukkaL
approved these changes
Jun 10, 2024
This was referenced Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving towards #15907
Fixes #17206
This PR enables polymorphic inference during unification. This will allow us to handle even more tricky situations involving generic higher-order functions (see a random example I added in tests). Implementation is mostly straightforward, few notes:
T <: Union[T, int], that later confuse the solver.module.some_func#0etc. for overloads namespaces instead.ParamSpeccrash to happen more often so I fix it in this same PR.__init__()that I am fixing here as well.Let's see
mypy_primerwill show us.