Make ARG_* into an actual enum class instead of just using int everywhere #10789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here This is cleaner and more precise and will allow us to add convenience methods to the class. (I added one convenience method so far, to verify that mypyc doesn't choke on it...)
| self.type = typ | ||
| self.unanalyzed_type = typ | ||
| self.is_overload = False | ||
| self.is_generator = False | ||
| self.is_generator: bool = False |
There was a problem hiding this comment.
Why add the type to only this field? Just curious
There was a problem hiding this comment.
Because something about making some of the things ArgKind's prompted __init__ to get deferred, I'd guess, which meant that the fields weren't all inferred properly, and this is one of the ones that got caught up in a problem with one of the use sites. I annotated some more to make it less weird, but sigh.
JelleZijlstra
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cleaner and more precise and will allow us to add convenience
methods to the class.
(I added one convenience method so far, to verify that mypyc doesn't
choke on it...)