Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94682: Build and test with OpenSSL 1.1.1q (gh-94683) #94683

Merged
merged 4 commits into from
Aug 29, 2022
Merged

gh-94682: Build and test with OpenSSL 1.1.1q (gh-94683) #94683

merged 4 commits into from
Aug 29, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 8, 2022 •
edited by bedevere-bot
Loading

@tiran tiran added type-security A security issue needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 8, 2022
@tiran tiran marked this pull request as ready for review August 18, 2022 10:58
@tiran tiran requested a review from a team as a code owner August 18, 2022 10:58
@tiran
Copy link
Member Author

tiran commented Aug 18, 2022

@pablogsal This should definitely land in 3.11.

@tiran
Copy link
Member Author

tiran commented Aug 18, 2022

@zooba Can you update https://github.com/python/cpython-bin-deps/tree/openssl-bin with OpenSSL 1.1.1q, please?

@pablogsal
Copy link
Member

@pablogsal This should definitely land in 3.11.

Makes sense, go ahead and land the backport 👍

@tiran tiran requested a review from a team as a code owner August 18, 2022 11:26
@tiran tiran changed the title gh-94682: Build and test with OpenSSL 1.1.1q gh-94682: Build and test with OpenSSL 1.1.1q (gh-94683) Aug 29, 2022
@tiran tiran merged commit 873554e into python:main Aug 29, 2022
@tiran tiran deleted the gh-94682-openssl111q branch August 29, 2022 16:19
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 873554ef84011773618911ffa698cea181cec9fd 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2022
@tiran @miss-islington
pythongh-94682: Build and test with OpenSSL 1.1.1q (pythongh-94683)
660f716 
(cherry picked from commit 873554e)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

GH-96390 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 29, 2022
@zware zware added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Aug 29, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 873554ef84011773618911ffa698cea181cec9fd 3.10

tiran added a commit to tiran/cpython that referenced this pull request Aug 29, 2022
@tiran
[3.10] pythongh-94682: Build and test with OpenSSL 1.1.1q (pythongh-9…
b5bb0b8 
…4683).

(cherry picked from commit 873554e)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 29, 2022
@bedevere-bot
Copy link

GH-96391 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 29, 2022
@miss-islington @tiran
gh-94682: Build and test with OpenSSL 1.1.1q (gh-94683)
882c7cf 
(cherry picked from commit 873554e)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit that referenced this pull request Aug 29, 2022
@tiran
[3.10] gh-94682: Build and test with OpenSSL 1.1.1q (gh-94683) (gh-96391
32a4501 
)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

@ned-deily ned-deily Awaiting requested review from ned-deily

@ambv ambv Awaiting requested review from ambv

Assignees

@tiran tiran

Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @pablogsal @miss-islington @bedevere-bot @zware