-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45191: Fix tb_lineno for multi-line expressions #28753
base: main
Are you sure you want to change the base?
Conversation
Merge remote-tracking branch 'upstream/main' into fix-issue-45191 bpo-45191: Fix tb_lineno for multi-line expressions
Merge remote-tracking branch 'upstream/main' into fix-issue-45191 aaa
Merge remote-tracking branch 'upstream/main' into fix-issue-45191 aaa
I think I made a mistake in the commit message, should I fix it? |
Both can be changed when/if we merge, so don't worry too much about it :) |
You need to rebase though, as you have conflicts in |
I think I've probably solved it. |
I'm not sure about this approach. If we have more then one arg, and they are on different lines, it will report the last line, but that's probably not what we want.
I would go for the 3.8, 3.9 behaviour from #89354 (comment) which means to fix the location for CALL. |
After thinking about it for a while, it certainly seems correct that the error location is aligned on the first line. By the way, should I delete the old |
I believe that some of the tests that this code is failing should change the expected result, what do you think? |
If the range is too wide then coverage can show code that never executed as if it did execute. As in:
|
Sorry for the delay in replying. |
https://bugs.python.org/issue45191