-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The canvas cannot be cleared after running turtledemo clock #123370
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I'd like either the spam discussion deleted or the meat (opening post and below moved to a new issue and deleted here. |
I deleted my own comment, leaving hugovk's. The bug now is that drawn text will not be cleared. I tried to solve this problem, including stopIt func self.screen.clear()
self.canvas.update()
self.canvas.delete("all") But all didn't work. I guess this bug has to do with |
I submitted a PR yesterday, but I noticed that the turtledemo did not set the codeowner to review the request. Could Terry take a review please, Thanks! |
I just added self as turtledemo codeowner. I'd like to see a follow-up 'modernize PR to
Or for 1 & 2, a new issue to also modernize other files with obsolete and bloated docstrings and German names and comments. Note that tearing off Examples menu makes it easy to look through files quickly.
|
This problem is present in every file and can be changed in the new PR
I've replaced this https://github.com/python/cpython/pull/123457/files
I think it's uglier :(
Agree |
For suggestion 3, I forgot that changing the base length requires increasing the base angles and decreasing the tip angle (and changing the turns the opposite amount) so that the 2 half bases meet and the stem is still a single line.
Before closing, I will open at least 2 new issues for changes that I think can and should be backported, with justifications. |
In this related PR, I ultimately decided to only fix this bug. However, on the left side of the turtledemo, users can see the code for the example case, so I don't want to add complexity and should try to keep it as simple as possible (for 5, backport should keep German names) |
…#123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change.
…tledemo.clock (pythonGH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) Co-authored-by: Wulian <xiguawulian@gmail.com>
…o.clock (gh-123457) (#125653) [3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clock (GH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) Co-authored-by: Wulian <xiguawulian@gmail.com>
…tledemo.clock (pythongh-123457) (pythonGH-125653) [3.13] pythongh-123370: Fix the canvas not clearing after running turtledemo.clock (pythonGH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) (cherry picked from commit 30d7e9e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Wulian <xiguawulian@gmail.com>
…rtledemo.clock (gh-123457) (GH-125653) (#125656) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) (cherry picked from commit 30d7e9e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Wulian <xiguawulian@gmail.com>
Bug report
Bug description:
First, run turtledemo clock. Then stop
When the clock stops running, the date appears, and the clear button becomes unusable. After switching to other files, the date still remains visible. Even after other files finish, pressing the clear button still cannot clear the date, but it can clear the drawings of the current file.
Linked PRs
The text was updated successfully, but these errors were encountered: