Fix self.instance._outcome is None case in #173
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ydshieh! Can you include a test that fails without this patch to ensure we do not regress this in the future by accident? A separate unittest using the reproducer you posted in the issue is enough. |
for more information, see https://pre-commit.ci
ydshieh
commented
Dec 9, 2024
tests/test_subtests.py
Outdated
| @@ -336,6 +336,32 @@ def test_foo(self): | |||
| ["collected 1 item", "* 3 xfailed, 1 passed in *"] | |||
| ) | |||
|
|
|||
| # A test for https://github.com/pytest-dev/pytest-subtests/issues/173 | |||
There was a problem hiding this comment.
only with pytest case.
nicoddemus
reviewed
Dec 9, 2024
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
…btests into fix_none_issue
|
Let me know if this commit works :-) |
loadams
added a commit
to microsoft/DeepSpeed
that referenced
this pull request
Dec 10, 2024
The issue we encountered was covered here: pytest-dev/pytest-subtests#173 And is resolved with the latest changes from this PR: pytest-dev/pytest-subtests#174, and is published in the latest version 0.14.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #173.
When a test is decorated with
unittest.skip,self.instance._outcomewould beNoneand we need to take this into account.