Use pre-commit in project #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
commented
Aug 11, 2019
tests/test_verify_base_url.py
Outdated
| from requests.packages.urllib3.util.retry import Retry | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def httpserver(httpserver): | ||
| return httpserver |
There was a problem hiding this comment.
For some reason, some of the tests fails when using python 2.7 without this, seemingly, redundant fixture. Any idea why, @nicoddemus ?
Tried replacing it with pytestmark = pytest.mark.usefixture("httpserver") without success.
There was a problem hiding this comment.
Or maybe @davehunt knows/remembers?
There was a problem hiding this comment.
I would agree this looks redundant, but regretfully I don't recall why this was necessary.
There was a problem hiding this comment.
I just added it back, with a note about removing it when we drop 2.7 support.
davehunt
requested changes
Aug 12, 2019
development.rst
Outdated
| Development | ||
| =========== | ||
|
|
||
| To contribute to `pytest-html` you can use `Pipenv`_ to manage |
davehunt
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
blackwasn't used previously, a lot of the changes are due to running it.