-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setuptools to install dependency #56
Conversation
Note: minimum python version has been updated as protobuf min version requires python 3.8 |
@mnm-matin it would be great to agree on this and bump a new version 0.2.3 soon to then update the conda installation. My advice is not to merge that PR to avoid having a breaking version into conda and skip 0.2.2 in conda. |
lgtm. high quality pr 🚀🚀 ready to merge? @davide-f |
Many thanks :D there is only a minor thing on about the VERSION handling that I'm checking. The next step is try to prepare the new release v2.3 or v3 as you prefer and check if we experience issues with pip/conda installations |
v2.3 sounds good! |
Many thanks :) merged, I'll prepare the release and check how it goes :) |
@mnm-matin Update: I've done as discussed and tried to release the new version. Would be great your revision/comment/action here when you have time: Many thanks! |
@mnm-matin unfortunately we still have the issue with pypi and to avoid committing to test, it would be great to have better clarity on the options to push to pypi. I've added 2FA for pypi |
What does this PR do?
Fixes Issue #55
Type of Change