Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools to install dependency #56

Merged
merged 12 commits into from
Dec 12, 2024

Conversation

davide-f
Copy link
Member

What does this PR do?

Fixes Issue #55

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code or workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@davide-f
Copy link
Member Author

Note: minimum python version has been updated as protobuf min version requires python 3.8

@davide-f
Copy link
Member Author

@mnm-matin it would be great to agree on this and bump a new version 0.2.3 soon to then update the conda installation.
In conda, we have conda-forge/earth-osm-feedstock#5 that fixes the changes of recipe/meta.yml but it is failing.

My advice is not to merge that PR to avoid having a breaking version into conda and skip 0.2.2 in conda.
When the new PR is triggered for v0.2.3 or 0.3, then we can use that as draft for the new version.

@davide-f davide-f requested a review from mnm-matin November 28, 2024 08:53
@mnm-matin
Copy link
Member

mnm-matin commented Dec 11, 2024

lgtm. high quality pr 🚀🚀

ready to merge? @davide-f

@davide-f
Copy link
Member Author

davide-f commented Dec 11, 2024

Many thanks :D there is only a minor thing on about the VERSION handling that I'm checking.

The next step is try to prepare the new release v2.3 or v3 as you prefer and check if we experience issues with pip/conda installations

@davide-f davide-f marked this pull request as draft December 11, 2024 10:55
@mnm-matin
Copy link
Member

v2.3 sounds good!

@davide-f davide-f marked this pull request as ready for review December 12, 2024 10:22
@davide-f davide-f merged commit 0068ac3 into pypsa-meets-earth:main Dec 12, 2024
2 checks passed
@davide-f
Copy link
Member Author

Many thanks :) merged, I'll prepare the release and check how it goes :)

@davide-f
Copy link
Member Author

@mnm-matin Update: I've done as discussed and tried to release the new version.
The building works, but in the publishing there is an issue maybe related to permissions on PyPI?

Would be great your revision/comment/action here when you have time:
#55 (comment)

Many thanks!

@davide-f
Copy link
Member Author

@mnm-matin unfortunately we still have the issue with pypi and to avoid committing to test, it would be great to have better clarity on the options to push to pypi. I've added 2FA for pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants