-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAQ entry about requesting new Trove classifiers #3410
Conversation
ping @brainwane on this. Maybe we should also add a new github issue template for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more specific about what we need from the requester?
Sure - beyond the name of the classifier is there any other info we need? |
We generally ask for some justification on why a classifier should be added. We have an already long list and we don’t want to inflate them further with (more) classifiers that nobody would use.
…Sent from my iPhone
On Mar 26, 2018, at 1:21 PM, Jon Wayne Parrott ***@***.***> wrote:
Can we be more specific about what we need from the requester?
Sure - beyond the name of the classifier is there any other info we need?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
More details added in 39a99e8 |
This sounds like a good idea! "Adding a trove classifier? (a) name of new classifier (b) why don't the existing classifiers fit this need?" |
warehouse/templates/pages/help.html
Outdated
<p> | ||
If you would like to request a new Trove classifer please file a bug on our <a href="https://github.com/pypa/warehouse/issues" target="_blank" rel="noopener">issue tracker</a>. Please include the name of the requested classifier and a brief justification of why it is important. | ||
</p> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the {% macro code_of_conduct() %}
block here as it is in other similar answers that are primarily about filing an issue. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d230e29
Thanks @jonparrott ! Following from my previous comment - could you please add a new GitHub template (see It should be named 'request-trove-classifier.md' and include something like: ## The name of the classifier you would like to add
<-- Classifier name -->
## Why do you want to add this classifier?
<!-- Please include a brief explanation to justify your request. Why do the current classifiers not meet your need? --> Then we can change the link to the issue tracker to use this GitHub template. It would also be cool if we could apply the 'classifier request' badge. The docs for how to do this are here: https://help.github.com/articles/about-automation-for-issues-and-pull-requests-with-query-parameters/ Let me know if anything is unclear, or you need help :) |
<!-- | ||
Please include a brief explanation to justify your request. | ||
Why do the current classifiers not meet your need? | ||
How many packages to you expect to use this new classifier? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm a little unclear -- do you mean how many different PyPI projects? I figure usually that's what we want to ask, but I am open to being told differently!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, project is the right terminology. You would think that I would be better about this. :)
Fixed in ba7560f
@@ -246,6 +248,12 @@ <h3 id="file-name-reuse">{{ file_name_reuse() }}</h3> | |||
To avoid this situation, <a href="https://packaging.python.org/guides/using-testpypi/">use Test PyPI to perform and check your upload first</a>, before uploading to <a href="https://pypi.org">pypi.org</a>. | |||
</p> | |||
|
|||
<h3 id="new-classifier">{{ new_classifier() }}</h3> | |||
<p> | |||
If you would like to request a new Trove classifier please file a bug on our <a href="https://github.com/pypa/warehouse/issues/new?template=new-trove-classifier.md" target="_blank" rel="noopener">issue tracker</a>. Please include the name of the requested classifier and a brief justification of why it is important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this wording -- thanks.
:( I'll make a separate PR once this is merged. |
* Add FAQ entry about requesting new Trove classifiers * Add issue template
Fixes #3028