Allow multiple attestations per distribution #17134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
di
reviewed
Nov 21, 2024
There was a problem hiding this comment.
As an aside, would be nice if https://docs.pypi.org/attestations/#supported-attestations went into a bit more detail about this behavior. Can be in this PR or another.
facutuesca
force-pushed
the
ft/allow-multiple-attestations
branch
from
fbfeca4 to
2563648
Compare
Pushed a commit with the doc change |
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
force-pushed
the
ft/allow-multiple-attestations
branch
from
2563648 to
b7baedf
Compare
di
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that SLSA provenances are supported in PEP-740 attestations, this PR removes the limit of 1 attestation per file.
This is bumped to 2 attestations per file, one per predicate type supported in PEP-740. This should allow users to upload both SLSA provenance and PyPI publish attestations for each distribution file.
This is part of #17001.
cc @woodruffw @di