Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install for local sdist packages #818

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Fix install for local sdist packages #818

merged 1 commit into from
Oct 4, 2017

Conversation

techalchemy
Copy link
Member

@techalchemy
Fix install for local sdist packages
bb32f66 
* Fixes pypa#817
* Packages werent being identified as local files
* Therefore they were not being given a path
* We were trying to resolve them with pypi
@kennethreitz kennethreitz merged commit 6889780 into pypa:master Oct 4, 2017
@kennethreitz
Copy link
Contributor

thanks!

techalchemy added a commit to techalchemy/pipenv that referenced this pull request Oct 10, 2017
@techalchemy
Introduces a test for PR pypa#818 and issue pypa#817 local sdists
5dd38a1 
Signed-off-by: Dan Ryan <dan@danryan.co>
nateprewitt added a commit that referenced this pull request Oct 12, 2017
@nateprewitt
Merge pull request #868 from techalchemy/add-pipenv-zipfile-install-test
8685ba8 
Introduces a test for PR #818 and issue #817 local sdists
@krismolendyke krismolendyke mentioned this pull request Oct 17, 2017
Merged
@techalchemy techalchemy deleted the non-editable-file-fix branch April 1, 2018 17:14
@StephenWithPH StephenWithPH mentioned this pull request May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipenv does not support installing from local source packages
2 participants
@techalchemy @kennethreitz