Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more_itertools in vendor isn't used? #5044

Closed
oz123 opened this issue Apr 12, 2022 · 1 comment
Closed

more_itertools in vendor isn't used? #5044

oz123 opened this issue Apr 12, 2022 · 1 comment
Assignees
@matteius

Comments

@oz123
Copy link
Contributor

oz123 commented Apr 12, 2022

I am not sure about this, but it seems that this vendord package isn't really used.
Some code was borrowed in the vendord vistir. I don't see it imported anywhere.

~/Software/pipenv $ grep -r more_iter
pipenv/vendor/more_itertools/recipes.pyi:"""Stubs for more_itertools.recipes"""
pipenv/vendor/more_itertools/recipes.py:        >>> from more_itertools import unique_everseen
pipenv/vendor/more_itertools/more.pyi:"""Stubs for more_itertools.more"""
pipenv/vendor/more_itertools/more.py:        "collate is no longer part of more_itertools, use heapq.merge",
pipenv/vendor/more_itertools/more.py:        >>> from more_itertools import consume
pipenv/vendor/more_itertools/more.py:        >>> from more_itertools import consume
pipenv/vendor/more_itertools/more.py:        more_itertools.more.UnequalIterablesError: Iterables have different
pipenv/vendor/more_itertools/more.py:        >>> from more_itertools import seekable
pipenv/vendor/more_itertools/more.py:        >>> from more_itertools import chunked
pipenv/vendor/more_itertools/more.py:        >>> from more_itertools import peekable
pipenv/vendor/more_itertools/more.py:      ``more_itertools.AbortThread`` exception.
pipenv/vendor/vistir/misc.py:    from https://github.com/erikrose/more-itertools/blob/master/more_itertools/recipes.py
pipenv/vendor/vistir/misc.py:    from https://github.com/erikrose/more-itertools/blob/master/more_itertools/more.py
grep: pipenv/vendor/vistir/__pycache__/misc.cpython-36.pyc: binary file matches
grep: pipenv/vendor/vistir/__pycache__/misc.cpython-39.pyc: binary file matches
grep: pipenv/vendor/vistir/__pycache__/misc.cpython-37.pyc: binary file matches
grep: .git/index: binary file matches
grep: .git/objects/pack/pack-4b2ffee50a8cf09f7755b50c14199f1e02280236.pack: binary file matches

Can this be removed?
@oz123
Copy link
Contributor Author

oz123 commented Apr 12, 2022

Playing Indiana Jones here:

more_itertools was added in: b5892c1 together with zipp version 0.6.0. This version used more itertools.

However, zipp removed `more_itertools in version 1.1.0.
jaraco/zipp@088b0cf

Hence, yes. This vendord packages can be removed.

@matteius matteius mentioned this issue Apr 14, 2022
Merged
2 tasks
@matteius matteius added the PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. label Apr 14, 2022
@matteius matteius removed the PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matteius matteius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matteius @oz123