Allow overriding _f2c_fixes.py from user #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Interesting, thanks @ryanking13. Looks reasonable for now. I'm currently working on making a fork of f2c with modifications that suit our needs so hopefully we can get rid of f2c_fixes. |
Cool. That sounds ambitious :)
Yeah, for now, I am trying to remove all annoying parts when unvendoring pyodide-build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most parts of pyodide-build are decoupled with pyodide/pyodide,
_f2c_fixes.pyfile that is used to build scipy is highly coupled with the scipy recipe in pyodide/pyodide.It would be very inefficient if we need to update pyodide-build whenever we fix scipy (e.g. pyodide/pyodide#4818). Therefore, this add a private config variable
_f2c_fixes_wrapper, which allows users to modify override_f2c_fixes.pyfile without touching pyodide-build itself.