Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a pyodide-py package #909

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Create a pyodide-py package #909

merged 1 commit into from
Dec 22, 2020

Conversation

rth
Copy link
Member

@rth rth commented Dec 21, 2020 •
edited
Loading

Creates a pyodide-py Python package (still imported as pyodide).

Closes #896

This is fully backward compatible import wise, but should facilitate code organization for future PRs (and in particular #875)

cc @hoodmane @casatir

@casatir
Copy link
Contributor

casatir commented Dec 21, 2020

Thanks @rth! It looks great! I have a complete console with correct repr, tab completion, and clean namespace. I'll rebase my work on top of your when merged.

@rth rth merged commit ce96a51 into pyodide:master Dec 22, 2020
@rth rth deleted the pyodide-py-package branch December 22, 2020 07:47
@rth
Copy link
Member Author

rth commented Dec 22, 2020

Thanks for the feedback @casatir ! Don't hesitate to also open several PR if it's a lot of changes for #875 (particularly since we squash commits).

@rth rth mentioned this pull request Dec 22, 2020
Merged
joemarshall pushed a commit to joemarshall/pyodide that referenced this pull request Jan 3, 2021
@rth @joemarshall
Create a pyodide-py package (pyodide#909)
2477db1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a pyodide Python package
2 participants
@rth @casatir