Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for dyncall_so patch #908

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Add tests for dyncall_so patch #908

merged 1 commit into from
Dec 22, 2020

Conversation

dalcde
Copy link
Contributor

@dalcde dalcde commented Dec 21, 2020

No description provided.

@dalcde
Copy link
Contributor Author

dalcde commented Dec 21, 2020

It would be nice if there were an easy way to make sure the tests fail without the patch. It is slightly tricky because the dyncall_so test would fail for a different reason if the emulate_pointer.patch is not applied, so if we simply don't patch at all we won't actually test dynCall_so.patch.

@dalcde
Copy link
Contributor Author

dalcde commented Dec 21, 2020

Another issue with this test is that without the patch, the error message we get is not the same as the one we get from test_brentq, but they seem similar in spirit.

@dalcde dalcde merged commit 108c613 into pyodide:master Dec 22, 2020
joemarshall pushed a commit to joemarshall/pyodide that referenced this pull request Jan 3, 2021
@dalcde @joemarshall
Add tests for dyncall_so patch (pyodide#908)
ae01e6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dalcde