Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document some emsdk patches #863

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Document some emsdk patches #863

merged 1 commit into from
Dec 15, 2020

Conversation

dalcde
Copy link
Contributor

@dalcde dalcde commented Dec 15, 2020

No description provided.

@dalcde
Copy link
Contributor Author

dalcde commented Dec 15, 2020

This addresses part of #857. There are two remaining emsdk patches:

  • The emcc-python38 patch will be removed in Upgrade to emscripten 1.38.42 #843 because it is upstreamed
  • I haven't looked into the dyncall patch yet, and it will have to be modified when upgrading to 1.38.43, and it can be addressed then.

@rth
Copy link
Member

rth commented Dec 15, 2020

Thanks!

@rth rth merged commit 9cd79f4 into pyodide:master Dec 15, 2020
@dalcde dalcde deleted the doc branch December 18, 2020 01:00
@dalcde dalcde mentioned this pull request Dec 18, 2020
Merged
joemarshall pushed a commit to joemarshall/pyodide that referenced this pull request Jan 3, 2021
@dalcde @joemarshall
Document some emsdk patches (pyodide#863)
6391a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalcde @rth