New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD Fix emcc warning on Python3.8 #720

Merged

rth merged 1 commit into pyodide:master from rth:emcc-py38-warning

Jul 11, 2020

Member

rth commented Jul 11, 2020

Fixes a minor but very frequently occurring emcc warning after updating to Python 3.8 in #712

/src/emsdk/emsdk/emscripten/tag-1.38.31/emcc.py:819: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  newargs = [arg for arg in newargs if arg is not '']
/src/emsdk/emsdk/emscripten/tag-1.38.31/emcc.py:939: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  newargs = [a for a in newargs if a is not '']

The added patch will no longer be necessary once we update emscripten to more recent versions e.g. #480 and #476


          Fix emcc warning on Python3.8

1be8882

rth merged commit ec249dc into pyodide:master

rth deleted the emcc-py38-warning branch

July 11, 2020 11:23

rth added this to the 0.16.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet