Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use sdk-fastcomp-tag-<version> for emscripten #589

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

aseering
Copy link
Contributor

Because sdk-tag- is no longer available upstream.

@aseering
Copy link
Contributor Author

The build here appears to fail with:

c++: fatal error: Killed signal terminated program cc1plus

I also see a handful of "Cannot allocate memory" messages in the build.

The build works for me locally. But I have lots of RAM. Maybe there are system-resource issues with CircleCI?

@wlach
Copy link
Contributor

wlach commented Dec 30, 2019

The build works for me locally. But I have lots of RAM. Maybe there are system-resource issues with CircleCI?

Yeah, this would be my guess. It looks like we're running make with -j35, which could result in a lot of files being compiled simultaneously:

Working directory: /home/circleci/repo/emsdk/emsdk/fastcomp-clang/tag-e1.38.30/build_tag-e1.38.30_64
Command '['cmake', '--build', '.', '--', '-j35']' returned non-zero exit status 2.
Installation failed!

Note that we don't normally compile the emsdk unless it's changed (best I can tell), so it's possible this has been a problem for a while but we just haven't noticed it yet.

Looking at the emscripten source, it appears that they have an EMCC_CORES setting which might keep this under control? Might be worth trying this:

https://github.com/emscripten-core/emscripten/blob/34ea2d91e87ee1d1fa589e08013cfcb2f59f030c/.circleci/config.yml#L10

(this is just a guess, I am not sure if this is the right setting to change)

@wlach
Copy link
Contributor

wlach commented Dec 31, 2019

Awesome, thank you @aseering! That seemed to fix it, the only tests that are now failing are the chrome tests, which were broken before. I'm going to go ahead and merge.

@wlach wlach merged commit 6a02cab into pyodide:master Dec 31, 2019
@aseering
Copy link
Contributor Author

great, glad it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants