Update pyodide py-compile command to accept list of files to exclude
#4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
changed the title
py-compile command to accept list of files to excludepyodide py-compile command to accept list of files to exclude
3 tasks
|
Thank you for the review! |
ryanking13
added a commit
to ryanking13/pyodide-build
that referenced
this pull request
Jul 11, 2024
ryanking13
added a commit
to pyodide/pyodide-build
that referenced
this pull request
Jul 11, 2024
…clude" (#9) - pyodide/pyodide#4911 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the package names are hard coded in
pyodide py-compilecommand. This PR makes it configurable, to loosen the coupling between pyodide-build and list of recipes in pyodide repository.I did a same thing to the
pyodide create-zipfilecommand before (#4723)Checklists