Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten 3.1.42 #4055

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Emscripten 3.1.42 #4055

merged 2 commits into from
Aug 9, 2023

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Aug 9, 2023

No description provided.

ryanking13
ryanking13 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it is okay to skip 3.1.41 and upgrade to 3.1.42 as the CI looks good.

There are some flaky tests, which don't seem related to this PR. Maybe we need to xfail it unless it can be fixed easily.

src/tests/test_typeconversions.py::test_wrong_way_track_proxies
src/tests/test_pyodide_http.py::test_pyfetch_coors_error

@hoodmane
Copy link
Member Author

hoodmane commented Aug 9, 2023

I'll at least look into test_wrong_way_track_proxies.

@hoodmane hoodmane merged commit f42c61d into pyodide:main Aug 9, 2023
@hoodmane hoodmane deleted the emscripten-3.1.42 branch August 9, 2023 15:38
@hoodmane hoodmane mentioned this pull request Aug 9, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking13 ryanking13 ryanking13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @ryanking13